[U-Boot] [PATCH 12/18] GCC4.6: Squash warnings in smsc95xx.c
Mike Frysinger
vapier at gentoo.org
Sun Oct 30 21:37:28 CET 2011
On Tuesday 25 October 2011 05:39:58 Marek Vasut wrote:
> --- a/drivers/usb/eth/smsc95xx.c
> +++ b/drivers/usb/eth/smsc95xx.c
>
> - addr_lo = cpu_to_le32(*((u32 *)eth->enetaddr));
> + addr_lo = cpu_to_le32(*eth->enetaddr);
pretty sure this is wrong. enetaddr is a uchar[], so your code now reads only
1 byte instead of 4.
that said, this code also seems to not be endian safe ...
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20111030/e9c7082c/attachment.pgp
More information about the U-Boot
mailing list