[U-Boot] [PATCH 12/18] GCC4.6: Squash warnings in smsc95xx.c

[Wolfgang Denk]

Dear Marek Vasut,

In message <201110302148.50367.marek.vasut at gmail.com> you wrote:
>
> > > -	addr_lo = cpu_to_le32(*((u32 *)eth->enetaddr));
> > > +	addr_lo = cpu_to_le32(*eth->enetaddr);
> > 
> > pretty sure this is wrong.  enetaddr is a uchar[], so your code now reads
> > only 1 byte instead of 4.
> > 
> > that said, this code also seems to not be endian safe ...
> > -mike
> 
> It's good anyone actually cares to properly review. Anyway, why does noone 
> actually care to fix all the damn warnings in their drivers before submitting 
> them in the first place ?!

GCC 4.6 has not been around that long.  Many people use less
bleading-edge tool chains - for a good reason.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Whenever people agree with me, I always think I must be wrong.
- Oscar Wilde