[U-Boot] [PATCH 20/20] x86: config: Enable AHCI support for coreboot

[Simon Glass]

Hi Graeme,

On Thu, Oct 25, 2012 at 9:15 PM, Graeme Russ <graeme.russ at gmail.com> wrote:
> Hi Simon,
>
> On Fri, Oct 26, 2012 at 1:36 PM, Simon Glass <sjg at chromium.org> wrote:
>> Hi Graeme,
>>
>> On Mon, Oct 22, 2012 at 11:33 PM, Graeme Russ <graeme.russ at gmail.com> wrote:
>>> Hi Simon,
>>>
>>> On Oct 23, 2012 4:42 PM, "Simon Glass" <sjg at chromium.org> wrote:
>>>>
>>>> Hi Graeme,
>>>>
>>>> On Mon, Oct 22, 2012 at 10:38 PM, Graeme Russ <graeme.russ at gmail.com>
>>>> wrote:
>>>> > Hi Simon,
>>>> >
>
> [snip]
>
>>>> > I plan on doing dev work on a AMD E350 based board 'soon'. The E350 is
>>>> > already supported by coreboot, so I'm planning on getting coreboot
>>>> > ported for this board and then run U-Boot from coreboot. So we can no
>>>> > longer assume all coreboot boards will be Intel based.
>>>>
>>>> Sounds good! Shall we rename coreboot.h to something like
>>>> chromebook-x86.h?
>>>
>>> Even better would be to use the model name (which I assume would make the
>>> x86 tag redundant)
>>
>> Well, the model is very device-specific. So far as U-Boot cares all
>> the models are basically the same. What differences there are are
>> taken care of by device tree differences. This is try on ARM for
>> machines which share the some SOC, and true for basically all x86
>> platforms.
>
> Key words: "So far" :) - If all the x86 chromebooks are essentially the
> same as far as U-Boot is concerned, then chromebook-x86.h will be fine.

OK

>
> I assume the plan is to create a common U-Boot binary with drivers for all
> supported chromebook hardware and use the device tree (initially built by
> passing coreboot tables, but maybe one day in the future passed by
> coreboot) to determine which drivers to initialise? The device tree would
> then be further fleshed out by U-Boot and passed to the Linux kernel?

Yes that's right, except that we don't currently pass an fdt to the
kernel. I suspect we will start doing this at some point.

Regards,
Simon

>
> Regards,
>
> Graeme