[U-Boot] [PATCH] ARM: tegra: TrimSlice: add support for USB1 port

[Lucas Stach]

Am Donnerstag, den 01.11.2012, 17:30 -0600 schrieb Stephen Warren:
> On 11/01/2012 05:17 PM, Lucas Stach wrote:
> > Hi Stephen,
> > 
> > Am Donnerstag, den 01.11.2012, 16:14 -0600 schrieb Stephen Warren:
> >> From: Stephen Warren <swarren at nvidia.com>
> >>
> >> TrimSlice's USB1 port has two purposes; it either acts as a device port
> >> hosting Tegra's USB recovery protocol, or acts as a host port connected
> >> to the internal USB->SATA bridge chip, which may in turn be connected to
> >> an SSD or HDD. Add the appropriate device tree and board configuration
> >> options to enable this port as a host port, and route the port to the
> >> SATA bridge using the VBUS GPIO.
> >>
> > Hm, I don't really like to abuse the VBUS GPIO for this function. As the
> > GPIO controlled routing is more a sort of pinmux can't you just add the
> > GPIO enable to pin_mux_usb()?
> 
> I don't know, I think it's fine. It's certainly this way in the kernel.
> And for all I know, this GPIO does actually affect VBUS as well as
> flipping any mux (and the more I think about that, the more likely it
> is) although I can't actually know for sure since I don't have the
> schematics.
> 
If it's really triggering VBUS I'm fine with this, but then the comment
in pin_mux_usb() is a bit off.