[U-Boot] [PATCH 1/3] tpm: Add casts for proper compilation

Wolfgang Denk wd at denx.de
Sat Nov 3 16:00:08 CET 2012


Dear Simon Glass,

In message <1351874667-23959-1-git-send-email-sjg at chromium.org> you wrote:
> From: Taylor Hutt <thutt at chromium.org>
> 
> When building for the Sandbox version, the casts in this change are
> necessary to avoid compilation issues.
> 
> Signed-off-by: Taylor Hutt <thutt at chromium.org>
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
>  drivers/tpm/generic_lpc_tpm.c |   10 +++++-----
>  1 files changed, 5 insertions(+), 5 deletions(-)

I see little sense in spending work on this code.  After all the time,
it is still unused and dead code in mainline - there is not a single
configuration which actually enables the necessary CONFIG_ options.,

I recommend to remove the whole TPM code instead.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
You are an excellent tactician, Captain. You let your second in  com-
mand attack while you sit and watch for weakness.
	-- Khan Noonian Singh, "Space Seed", stardate 3141.9


More information about the U-Boot mailing list