[U-Boot] [PATCH 16/17] console: Enable function to display console info
Wolfgang Denk
wd at denx.de
Sat Nov 3 16:15:03 CET 2012
Dear Simon Glass,
In message <1351902453-27956-17-git-send-email-sjg at chromium.org> you wrote:
> The CONFIG_SYS_CONSOLE_INFO_QUIET option should suppress the console
> information, but allow boards to display it later if required. Adjust
> the code to support this.
>
> This is used to avoid printing the information while the LCD display
> is not ready, since it only becomes ready when stdio init is complete.
>
> BRANCH=snow
Please get such comments out of the commit messages.
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
> common/console.c | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
This is broken. You miss the fact that stdio_print_current_devices()
gets called in a number of other places as well (you should have
asked yourself why it isn't a static function). See at least
board/mpl/mip405/mip405.c
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"In matrimony, to hesitate is sometimes to be saved." - Butler
More information about the U-Boot
mailing list