[U-Boot] [PATCH 1/3] tpm: Add casts for proper compilation

Wolfgang Denk wd at denx.de
Sun Nov 4 01:26:24 CET 2012


Dear Simon,

In message <CAPnjgZ0RV991pa7MeVxr463g-TkKa+rzF8Gn7R0_ZbZnOWOsZg at mail.gmail.com> you wrote:
> 
> > I recommend to remove the whole TPM code instead.
> 
> It is actually used in the x86 Chromebook, but the patch to enable it
> never made it to mainline. There was quite a bit of push-back on the
> x86 side at the time and the person working on it finally had enough
> :-(
> 
> I have recently taken this up again to see if we can get x86 into a
> better state for newer Intel chips and the latest x86 Chromebooks. The
> patch to enable the TPM there is:
> 
> http://patchwork.ozlabs.org/patch/190813/

I don;t see how this uses it in any way in U-Boot.  It still would not
even compile most of the code, right?

> I accept that it has sat there for a while without a board config to
> use it. But I would very much like to keep this code and see no sense
> in removing it now that it is actually in use.

Feel free to re-add it when there are any real users.

I've posted a removal patch.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
...when fits of creativity run strong, more than  one  programmer  or
writer  has  been  known to abandon the desktop for the more spacious
floor.                                             - Fred Brooks, Jr.


More information about the U-Boot mailing list