[U-Boot] [PATCH 3/3] Add stricmp() and strnicmp()

[Wolfgang Denk]

Dear Simon Glass,

In message <1351979121-3769-3-git-send-email-sjg at chromium.org> you wrote:
> strnicmp() is present but disabled. Make it available and define stricmp()
> also. There is a only a small performance penalty to having stricmp()
> call strnicmp(), so do this instead of a standalone function, to save code
> space.
> 
> BRANCH=none

Please get rid of such entries in the commit messages!!!!

Consider all patches that contain such entries as NAKed.

> +int strnicmp(const char *s1, const char *s2, size_t len);
> +
> +int stricmp(const char *s1, const char *s2);

Who are the users of this?   I object against adding dead code.

If users will be added later, this patch should go into the series
adding the users.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Severe culture shock results when experts from another protocol suite
[...] try to read OSI documents. The term "osified" is used to  refer
to  such  documents. [...] Any relationship to the word "ossified" is
purely intentional.                                - Marshall T. Rose