[U-Boot] [PATCH 2/3] md5: Fix gcc-4.7 build problem in md5
Wolfgang Denk
wd at denx.de
Sun Nov 4 01:39:22 CET 2012
Dear Simon,
In message <20121104003242.92729200056 at gemini.denx.de> I wrote:
>
> > /* Append length in bits and transform */
> > - ctx->in32[14] = ctx->bits[0];
> > - ctx->in32[15] = ctx->bits[1];
> > + memcpy(ctx->in + 14 * sizeof(__u32), ctx->bits, 2 * sizeof(__u32));
>
> This makes the code actually unreadable. Please add at least a
> comment what this is doing.
Actually I think this shoul dbe split into two memcpy commands, using
the addresses of the respective array elements directly, without such
manual pointer arithmetics.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"The number of Unix installations has grown to 10, with more
expected." - The Unix Programmer's Manual, 2nd Edition, June, 1972
More information about the U-Boot
mailing list