[U-Boot] [PATCH] TPM: remove dead code

[Simon Glass]

Hi Wolfgang,

On Sat, Nov 3, 2012 at 5:28 PM, Wolfgang Denk <wd at denx.de> wrote:
> Dear Simon,
>
> In message <CAPnjgZ0JLarq6r=sHe+cfbjkyuf6hRgGP4BR9u_aSug14MZcrg at mail.gmail.com> you wrote:
>>
>> On Sat, Nov 3, 2012 at 9:30 AM, Wolfgang Denk <wd at denx.de> wrote:
>> > The TPM code was added more than a year or 4 releases ago.  This was
>> > done under the proposition that board support that would actually use
>> > such code would be added soon.  However, nothing happened since.  The
>> > code has no users in mainline, and does not even get build for any
>> > configuration, so we cannot even tell if it compiles at all.
>> >
>> > Remove the unused code.  In in some far future actual users show up,
>> > it can be re-added easily.
>>
>> I think you may have missed the pending patches which make use of
>> this. it is important functionality for the Chromebooks (secure boot).
>
> No, I have not missed these.  But all the patch does is set
> CONFIG_GENERIC_LPC_TPM - there is still not a single user defining
> CONFIG_CMD_TPM, so what does this help?  We still have tons of dead
> code around.  Dump it!

So we need a board that defines the command also? I did not realise
that was a requirement - certainly I can add that command to the
boards also.

Upstreaming the code is a step-by-step process. The TPM is an
important component of secure boot, and things have to progress in
some sort of fashion. I do understand the dead code argument, but we
can't submit high-level code without the drivers it uses (and there
are many).

Regards,
Simon

>
> Best regards,
>
> Wolfgang Denk
>
> --
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> Unix: Some say the learning curve is steep,  but  you  only  have  to
> climb it once.                                      - Karl Lehenbauer