[U-Boot] [PATCH v2 1/2] arm: move C runtime setup code in crt0.S

Albert ARIBAUD albert.u.boot at aribaud.net
Sun Nov 4 19:01:26 CET 2012


Hi Vikram,

On Sun, 04 Nov 2012 20:36:14 +0530, Vikram Narayanan
<vikram186 at gmail.com> wrote:

> Hello Albert,

> > diff --git a/arch/arm/lib/crt0.S b/arch/arm/lib/crt0.S

> > +#ifndef CONFIG_SPL_BUILD
> 
> In some places the other style is used. "!(defined)".
> Any particular reasons for switching b/w these two styles?

None except heterogeneity. In V3 I'll make sure 'defined()' is used
everywhere in the new files or added code.

> > +	ldr	r0, =__bss_start	/* this is auto-relocated! */
> > +	ldr	r1, =__bss_end__	/* this is aotu-relocated! */
> 
> s/aotu/auto

Thanks for spotting this. Will fix in V3.

> Regards,
> Vikram

Amicalement,
-- 
Albert.


More information about the U-Boot mailing list