[U-Boot] [PATCH 1/3] fs: fix do_fsload() handling of optional arguments

Tom Rini trini at ti.com
Sun Nov 4 19:30:04 CET 2012


On Tue, Oct 30, 2012 at 11:28:55PM +0100, Beno??t Th??baudeau wrote:
> On Tuesday, October 30, 2012 11:04:17 PM, Stephen Warren wrote:
> > From: Stephen Warren <swarren at nvidia.com>
> > 
> > Most arguments to the shell command do_fsload() implements are
> > optional.
> > Fix the minimum argc check to respect that. Cater for the situation
> > where argv[2] is not provided.
> > 
> > Enhance both do_fsload() and do_ls() to check the maximum number of
> > arguments too. While this check would typically be implemented via
> > U_BOOT_CMD()'s max_args parameter, if these functions are called
> > directly, then that check won't exist.
> > 
> > Finally, alter do_ls() to check (argc >= 4) rather than (argc == 4)
> > so
> > that if the function is enhanced to allow extra arguments in the
> > future,
> > this test won't need to be changed at that time.
> > 
> > Signed-off-by: Stephen Warren <swarren at nvidia.com>
> [--snip--]
> 
> For the series:
> Reviewed-by: Beno??t Th??baudeau <benoit.thebaudeau at advansee.com>

And for the series, applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20121104/696f70e9/attachment.pgp>


More information about the U-Boot mailing list