[U-Boot] [PATCH 3/4] exynos5: Add DT based driver for SMSC92xx ethernet

[Simon Glass]

Hi Hatim,

On Mon, Nov 5, 2012 at 8:11 PM, Hatim Rv <rv.hatimali at gmail.com> wrote:
> Hi Simon,
>
> On Tue, Nov 6, 2012 at 7:12 AM, Simon Glass <sjg at chromium.org> wrote:
>> Hi Hatim,
>>
>> On Mon, Nov 5, 2012 at 2:18 AM, Hatim Ali <hatim.rv at samsung.com> wrote:
>>> Add device tree based ethernet driver for SMSC92xx controller on
>>> SMDK5250 boards.
>>>
>>> Signed-off-by: Hatim Ali <hatim.rv at samsung.com>
>>
>> Acked-by: Simon Glass <sjg at chromium.org>
>>
>> but see comment below
>>
>>>
[snip]
>>> +       /* Select and configure the SROMC bank */
>>> +       exynos_pinmux_config(PERIPH_ID_SROMC, config.bank);
>>
>> But from what I can see, the above function does not support setting
>> up a 16-bit SROMC. Perhaps the subject of a future patch?
>
> In the exynos_pinmux_config function, the GPIO banks GPY5 and GPY6 are
> both getting configured to support the 16-bit SROM controller.
>

OK I see, thank you.

Regards,
Simon