[U-Boot] [PATCH] common: fix help command breakage

Henrik Nordström henrik at henriknordstrom.net
Tue Nov 6 06:44:22 CET 2012


mån 2012-11-05 klockan 19:51 -0600 skrev Kim Phillips:
> commit 199adb601ff34bdbbd0667fac80dfe0a87bffc2b "common/misc: sparse
> fixes" broke the help command trying to fix the sparse error
> "command.c:44:38: error: bad constant expression".
> 
> As Henrik points out, the fix was bad because the commit used
> CONFIG_SYS_MAXARGS whereas the code intended to use the maximum
> number of commands (not arguments to a command).
> 
> this patch fixes both by making the allocation manually on the heap.
> 
> Reported-by: Henrik Nordström <henrik at henriknordstrom.net>
> Signed-off-by: Kim Phillips <kim.phillips at freescale.com>

Tested-by: Henrik Nordström <henrik at henriknordstrom.net>





More information about the U-Boot mailing list