[U-Boot] [PATCH] USB: add arrow key support to usb_kbd

Marek Vasut marex at denx.de
Tue Nov 6 23:56:37 CET 2012


Dear Simon Glass,

> Hi Marek,
> 
> On Tue, Nov 6, 2012 at 2:49 PM, Marek Vasut <marex at denx.de> wrote:
> > Dear Allen Martin,
> > 
> >> Check for scancodes for arrow keys and map them to ^F/^B, ^N/^P.
> >> Control characters are used instead of ANSI sequence because the
> >> queueing code in usb_kbd doesn't handle the data increase when one
> >> keypress generates 3 keycodes.  The real fix is to convert this driver
> >> to use the input subsystem and queue
> > 
> > If it's the real fix, then why not go for the real fix right away? :-(
> 
> Because it's a fair chunk of work

Let's either do it properly or not at all ... if I let you do these semi-
complete fixes, we'll end up with a stinking pile of crap like windows ...

> and also if we are doing USB we
> should probably do keyboard.c first.

Uh, I don't follow.

> USB would not be the first
> priority since so much of the logic / keycodes are different.

Sorry, I'm completely lost.

> Regards,
> Simon
> 
> >> but this allows arrow keys to
> >> work until this driver is converted.
> >> 
> >> Signed-off-by: Allen Martin <amartin at nvidia.com>
> >> ---
> > 
> > [...]
> > 
> > Best regards,
> > Marek Vasut

Best regards,
Marek Vasut


More information about the U-Boot mailing list