[U-Boot] [PATCH 09/10] arm: Move bootstage record for board_init_f() to after arch_cpu_init()
Simon Glass
sjg at chromium.org
Wed Nov 7 01:51:51 CET 2012
Hi Wolfgang,
On Sat, Nov 3, 2012 at 7:55 AM, Wolfgang Denk <wd at denx.de> wrote:
> Dear Simon Glass,
>
> In message <1351813330-23741-9-git-send-email-sjg at chromium.org> you wrote:
>> The timer may be inited in arch_cpu_init() so it is not safe to make a
>> bootstage mark before this is called. Arrange the code to fix this.
>>
>> We now get a correct time for board_init_f:
>>
>> Timer summary in microseconds:
>> Mark Elapsed Stage
>> 0 0 reset
>> 100,000 100,000 spl_start
>> 848,530 748,530 board_init_f
>> 907,301 58,771 board_init_r
>> 910,478 3,177 board_init
>>
>> Signed-off-by: Simon Glass <sjg at chromium.org>
>> ---
>> arch/arm/lib/board.c | 11 +++++++++--
>> 1 files changed, 9 insertions(+), 2 deletions(-)
>
> NAK as is. Please make sure to keep all arhcitectures in sync. The
> long term goal iss till to merge the lib/board.c files into a single,
> common one.
See my notes on the other patch, most of which apply here.
http://patchwork.ozlabs.org/patch/196419/
I don't believe this affects other architectures, but it is a problem
on at least exynos 5.
Regards,
Simon
>
> Best regards,
>
> Wolfgang Denk
>
> --
> DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> The universe contains any amount of horrible ways to be woken up,
> such as the noise of the mob breaking down the front door, the scream
> of fire engines, or the realization that today is the Monday which on
> Friday night was a comfortably long way off.
> - Terry Pratchett, _Moving Pictures_
More information about the U-Boot
mailing list