[U-Boot] [PATCH 1/3] tpm: Add casts for proper compilation

Simon Glass sjg at chromium.org
Wed Nov 7 17:20:03 CET 2012


Hi Wolfgang,

On Wed, Nov 7, 2012 at 5:06 AM, Wolfgang Denk <wd at denx.de> wrote:
> Dear Simon,
>
> In message <CAPnjgZ2p-Re5Hp13st-Q2CuP49azyZZxwNRZSAfhr_iUSGbNJQ at mail.gmail.com> you wrote:
>>
>> >> I accept that it has sat there for a while without a board config to
>> >> use it. But I would very much like to keep this code and see no sense
>> >> in removing it now that it is actually in use.
>> >
>> > Feel free to re-add it when there are any real users.
>> >
>> > I've posted a removal patch.
>>
>> Can you please explain what you mean by 'real users'? Are you looking
>> for an entire verified boot implementation before you will accept the
>> TPM driver?
>
> What exactly is this driver good for?  Which function does it provide
> that can be used on any board in mainline?  It looks to me that it's
> just sitting there, and does nothing good to anybody.
>
> I don't know if there are any other legitimate uses for a TPM driver
> in U-Boot, but if there are, none appear to be implemented by any
> mainline board, so why should we have this driver in mainline?

I replied on the other thread - hopefully we can agree a plan to move
this forward.

Regards,
Simon

>
> Best regards,
>
> Wolfgang Denk
>
> --
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> While money can't buy happiness, it certainly lets  you  choose  your
> own form of misery.


More information about the U-Boot mailing list