[U-Boot] [Drivers PATCH 17/19] imls: Add support to list images in NAND device

Scott Wood scottwood at freescale.com
Wed Nov 7 21:49:16 CET 2012


On 11/06/2012 11:15:42 PM, Vipin Kumar wrote:
> On 11/7/2012 5:00 AM, Scott Wood wrote:
>> On 11/02/2012 12:40:02 PM, Vipin Kumar wrote:
>>> +#if defined(CONFIG_CMD_NAND)
>>> + printf("\n");
>>> + nand_info_t *nand;
>>> + image_header_t image_header;
>>> + image_header_t *header = &image_header;
>>> + int nand_dev = nand_curr_device;
>>> + unsigned long img_size;
>>> + size_t hdr_size, read_len;
>>> + loff_t off;
>>> + unsigned int crc;
>>> + u_char *data;
>>> +
>>> + /* the following commands operate on the current device */
>>> + if (nand_dev < 0 || nand_dev >= CONFIG_SYS_MAX_NAND_DEVICE) {
>>> + puts("\nNo NAND devices available\n");
>>> + return 0;
>>> + }
>> 
>> Please move the NAND and NOR code into their own functions.
>> 
> 
> You mean I can separate the NOR list images code in one routine and  
> NAND in another?

Yes.

-Scott


More information about the U-Boot mailing list