[U-Boot] [PATCH 1/2] hush: Treat trailing || and && as incomplete statements

Wolfgang Denk wd at denx.de
Fri Nov 9 00:04:46 CET 2012


Dear Joe,

In message <1352405756-401-1-git-send-email-joe.hershberger at ni.com> you wrote:
> A || or && at the end of a command should behave just like an if
> statment that is not complete.
> 
> Signed-off-by: Joe Hershberger <joe.hershberger at ni.com>

I really appreciate your patches.  But after having spent some time on
hush bug fixes myself (I submitted a few patches some time ago - to
kill them later when I learned I was just chiseling at the top of
somce iceberg) I seriously doubt if it makes senxe to try fixing the
many, many bugs in the old version of hush that is included with
U-Boot.

You may have a look over the fence at what Barebox fixed in this area,
but the result will probably be the same.

I fear that such patches, while fixing a nasty problem here and there,
will create other and maybe even more nasty problems in unexpacted
areas.


My suggestion is to save such efforts, and rather spend the time on
adating a more recent version of hush to U-Boot; getting things like
shell functions or backtic evaluation would be more than welcome to
many of us, I guess.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Einstein argued that there must be simplified explanations of nature,
because God is not capricious or arbitrary. No  such  faith  comforts
the software engineer.                             - Fred Brooks, Jr.


More information about the U-Boot mailing list