[U-Boot] [PATCH 0/4] EXYNOS5: Add GPIO numbering feature

[Rajeshwari Birje]

Hi Minkyu,

Any comments on this patch set please do let me know.
If no comments I can resend the patches by re-basing them on latest
u-boot-samsung code.

Regards,
Rajeshwari Shinde.



On Tue, Aug 14, 2012 at 7:23 AM, Simon Glass <sjg at chromium.org> wrote:

> Hi,
>
> On Fri, Aug 10, 2012 at 5:05 AM, Minkyu Kang <promsoft at gmail.com> wrote:
> > Dear Rajeshwari Birje,
> >
> > On 10 August 2012 14:22, Rajeshwari Birje <rajeshwari.birje at gmail.com>
> wrote:
> >> Hi All,
> >>
> >> Do let me know if you have comments on these patch set.
> >>
> >> Regards,
> >> Rajeshwari Shinde
> >>
> >> On Mon, Aug 6, 2012 at 6:35 PM, Rajeshwari Shinde
> >> <rajeshwari.s at samsung.com> wrote:
> >>> This patchset adds GPIO numbering feature where pinmux setting
> >>> can be done just by seding the pin munber and we do not have to
> >>> remember which bank it belongs to.
> >>>
> >
> > Hm, I don't know about the need of this patch.
> > You said "we do not have to remember which bank it belongs to".
> > but, what is the different "gpio1->a0" and "GPIO_A00"?
> >
> > Also, new functions are almost same with current functions, do we
> > really need this patch?
>
> It is intended to support the generic GPIO interface which many other
> boards support (include/asm-generic/gpio.h). Rather than
> Samsung-specific things like gpio_cfg_pin(&bank, pin, value) we can
> use gpio_direction_output(), gpio_set_value(), etc.
>
> It is better to use the standard U-Boot interface where possible.
>
> >
> > Thanks.
> > Minkyu Kang.
> > --
> > from. prom.
> > www.promsoft.net
> > _______________________________________________
> > U-Boot mailing list
> > U-Boot at lists.denx.de
> > http://lists.denx.de/mailman/listinfo/u-boot
>
> Regards,
> Simon
>