[U-Boot] [PATCH 1/2] DEBUG: fix relocation address

Wolfgang Denk wd at denx.de
Wed Nov 21 09:24:41 CET 2012


Dear Tetsuyuki Kobayashi,

In message <1353476660-18018-2-git-send-email-koba at kmckk.co.jp> you wrote:
> U-Boot from NOR flash relocates itself to RAM erea. The relocation address is
> calaculated at runtime to get maxium contiguous space to load kernel. So it may
> vary after code changed. In the early debug phase it would be easier to handle
> if the relocation address does not change.
> This patch sets relocation address to fixed address specified by
> CONFIG_DEBUG_RELOC_FIX_ADDR. If there is no enough space after
> CONFIG_DEBUG_RELOC_FIX_ADDR, it is ignored.
> patch to kzm9g.h is a example. CONFIG_DEBUG_RELOC_FIX_ADDR should be defined at
> each config file.
> 
> Signed-off-by: Tetsuyuki Kobayashi <koba at kmckk.co.jp>
> ---
>  arch/arm/lib/board.c    |    9 ++++++++-
>  include/configs/kzm9g.h |    4 ++++
>  2 files changed, 12 insertions(+), 1 deletion(-)

NAK for this patch for the general reasons outlined oin my summary
reply to the cover letter.

In addition:

- If this is supposed to be a RFC patch series, then please add the
  RFC part to ALL patches, not only to the cover letter.

- Any changes to basic infrastucture like this have to be done in a
  general, architecture-independent way.  Doing this for ARM only is
  not acceptable.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Confound these ancestors.... They've stolen our best ideas!"
- Ben Jonson


More information about the U-Boot mailing list