[U-Boot] [PATCH v2 05/23] stdio: remove useless strncpy
Simon Glass
sjg at chromium.org
Thu Nov 22 20:12:49 CET 2012
From: Vincent Palatin <vpalatin at chromium.org>
The name is already copied when we memcpy() the whole structure.
This is because struct stdio_dev has this field:
char name[16]; /* Device name */
So the data is inline, rather than being a pointer.
Signed-off-by: Vincent Palatin <vpalatin at chromium.org>
Signed-off-by: Simon Glass <sjg at chromium.org>
---
Changes in v2:
- Add more comments to the stdio strncpy commit message
common/stdio.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/common/stdio.c b/common/stdio.c
index 605ff3f..c7a323f 100644
--- a/common/stdio.c
+++ b/common/stdio.c
@@ -135,7 +135,6 @@ struct stdio_dev* stdio_clone(struct stdio_dev *dev)
return NULL;
memcpy(_dev, dev, sizeof(struct stdio_dev));
- strncpy(_dev->name, dev->name, 16);
return _dev;
}
--
1.7.7.3
More information about the U-Boot
mailing list