[U-Boot] [PATCH] mx23: Add POWER and CLKCTRL register definitions

Otavio Salvador otavio at ossystems.com.br
Sun Nov 25 03:57:21 CET 2012


On Sun, Nov 25, 2012 at 12:54 AM, Marek Vasut <marex at denx.de> wrote:
> Dear Otavio Salvador,
>
>> On Sat, Nov 24, 2012 at 10:21 PM, Marek Vasut <marex at denx.de> wrote:
>> > Add register definitions for the i.MX23 power control block and
>> > clock control block. These are essential for the basic bootstrap
>> > of the i.MX23. Also, properly include them in imx-regs.h .
>> >
>> > Signed-off-by: Marek Vasut <marex at denx.de>
>> > Cc: Stefano Babic <sbabic at denx.de>
>>
>> Please don't merge it now as this has been already done in my branch with
>> mx23.
>
> I'm attaching a proper diff against your branch. There are multiple wrong and
> missing bits in your branch. This patch is done by processing the FSL-provided
> header file and cross-checking with the datasheet.
>
> So, this patch is right, yours is wrong. Sorry.

I am not saying mine is perfect, far from it. And we can fix it in the
branch but please don't push it until we finish mx23 bootstrap.

Let's work in same code, not duplicate work...

-- 
Otavio Salvador                             O.S. Systems
E-mail: otavio at ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br


More information about the U-Boot mailing list