[U-Boot] [PATCH 02/22] ARM: sunxi: MMC driver

[Wolfgang Denk]

Dear Henrik Nordström,

In message <1353843479.17518.14.camel at home.hno.se> you wrote:
> This adds a basic MMC driver for Allwinner sun4i/sun5i family of SoC
> this driver is limited to a single MMC channel.
> 
> Signed-off-by: Tom Cubie <tangliang at allwinnertech.com>
> Signed-off-by: Henrik Nodstrom <henrik at henriknordstrom.net>
> Signed-off-by: Stefan Roese <sr at denx.de>

???

> --- a/drivers/mmc/Makefile
> +++ b/drivers/mmc/Makefile
> @@ -47,6 +47,7 @@ COBJS-$(CONFIG_S5P_SDHCI) += s5p_sdhci.o
>  COBJS-$(CONFIG_SH_MMCIF) += sh_mmcif.o
>  COBJS-$(CONFIG_TEGRA_MMC) += tegra_mmc.o
>  COBJS-$(CONFIG_DWMMC) += dw_mmc.o
> +COBJS-$(CONFIG_MMC_SUNXI) += sunxi_mmc.o

Please keep / make list sorted.

> diff --git a/drivers/mmc/sunxi_mmc.c b/drivers/mmc/sunxi_mmc.c
> new file mode 100644
> index 0000000..05bc231
> --- /dev/null
> +++ b/drivers/mmc/sunxi_mmc.c
...
> +#undef SUNXI_MMCDBG
> +
> +#ifdef SUNXI_MMCDBG
> +#define MMCDBG(fmt...)	printf("[mmc]: "fmt)

Please do not invent your own debug facilities;  instead, use the
default ones.

As is, this all is dead code and should be removed.

> +static void dumphex32(char *name, char *base, int len)
> +{
> +	__u32 i;
> +
> +	printf("dump %s registers:", name);
> +	for (i = 0; i < len; i += 4) {
> +		if (!(i & 0xf))
> +			printf("\n0x%p : ", base + i);
> +		printf("0x%08x ", readl(base + i));
> +	}
> +	printf("\n");
> +}

And we do not have any code like that yet that could be reused?


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Let the programmers be many and the managers few -- then all will  be
productive.               -- Geoffrey James, "The Tao of Programming"