[U-Boot] [PATCH 02/22] ARM: sunxi: MMC driver

[Wolfgang Denk]

Dear Luka Perkov,

In message <20121125143332-9180 at mutt-kz> you wrote:
>
...
> Why not reuse something from existing uboot code ? (exaple from api/api.c):
> 
>  36 #define DEBUG
>  37 #undef DEBUG

NAK.  Please never ever do that. 

>  53 #ifdef DEBUG
>  54 #define debugf(fmt, args...) do { printf("%s(): ", __func__); printf(fm=
> t, ##args); } while (0)
>  55 #else
>  56 #define debugf(fmt, args...)
>  57 #endif

More NAK!!! We have standard debug utilities, and do not need to
reinvent the wheel every time we come around.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Looks clean and obviously correct to me, but then _everything_ I
write always looks obviously correct to me.  - Linus Torvalds in
<Pine.LNX.4.10.10012090054360.791-100000 at penguin.transmeta.com>