[U-Boot] [Patch 2/2] MIPS: do not modify variable before relocate_code
Daniel Schwierzeck
daniel.schwierzeck at gmail.com
Sun Nov 25 21:56:01 CET 2012
2012/11/24 Zhi-zhou Zhang <zhizhou.zh at gmail.com>:
> Because timestamp is declared as `static', we needn't initialize
> it by writing it a zero. If we do it before relocate_code, we
> will write into a flash address(0xffffffffbfc0xxxx).
>
> Signed-off-by: Zhi-zhou Zhang <zhizhou.zh at gmail.com>
> ---
> arch/mips/cpu/mips32/time.c | 1 -
> arch/mips/cpu/mips64/time.c | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/arch/mips/cpu/mips32/time.c b/arch/mips/cpu/mips32/time.c
> index 350896a..09fc842 100644
> --- a/arch/mips/cpu/mips32/time.c
> +++ b/arch/mips/cpu/mips32/time.c
> @@ -36,7 +36,6 @@ static unsigned long timestamp;
> int timer_init(void)
> {
> /* Set up the timer for the first expiration. */
> - timestamp = 0;
> write_c0_compare(read_c0_count() + CYCLES_PER_JIFFY);
>
> return 0;
> diff --git a/arch/mips/cpu/mips64/time.c b/arch/mips/cpu/mips64/time.c
> index 5154280..720f7b7 100644
> --- a/arch/mips/cpu/mips64/time.c
> +++ b/arch/mips/cpu/mips64/time.c
> @@ -37,7 +37,6 @@ static unsigned long timestamp;
> int timer_init(void)
> {
> /* Set up the timer for the first expiration. */
> - timestamp = 0;
> write_c0_compare(read_c0_count() + CYCLES_PER_JIFFY);
>
> return 0;
> --
> 1.7.9.5
>
applied to u-boot-mips/master with a tiny fixup of the commit summary, thanks
--
Best regards,
Daniel
More information about the U-Boot
mailing list