[U-Boot] [PATCH 06/22] ARM sunxi: Basic GPIO driver
Marek Vasut
marex at denx.de
Sun Nov 25 22:47:22 CET 2012
Dear Wolfgang Denk,
> Dear Henrik Nordström,
>
> In message <1353843623.17518.17.camel at home.hno.se> you wrote:
> > GPIO driver for Allwinner sun4i/sun5i family of SoCs
> >
> > GPIO Pins are named by their symbolic pin names P<g><#>
> > such as PH19 or H19.
> >
> > Note: This do not perform any validation if the pin is in use
> > for some other I/O function. Use with care.
>
> SoB missing.
>
>
> Um.... are these patches actually bisectable??? It appears not; for
> example, you reference gpio_direction_input() in ealier patches, but
> define it only now.
>
> This patch series need a full rework.
It needs a bit of polishing ;-)
Best regards,
Marek Vasut
More information about the U-Boot
mailing list