[U-Boot] [PATCH 2/2] Makefile: Accept target names in all lower case to ease matching

Henrik Nordström henrik at henriknordstrom.net
Mon Nov 26 01:02:59 CET 2012


sön 2012-11-25 klockan 21:04 +0100 skrev Wolfgang Denk:

> Well, these are make targets, so they are definitely case sensitive.
> 
> >  if [ \( $# -eq 2 \) -a \( "$1" = "-A" \) ] ; then
> >  	# Automatic mode
> > -	line=`egrep -i "^[[:space:]]*${2}[[:space:]]" boards.cfg` || {
> > +	line=`egrep "^[[:space:]]*${2}[[:space:]]" boards.cfg` || {
> 
> Did you test what gets broken by this patch?

All normal "make targetname" is unaffected by the change as they are
case sensitive.

What gets broken by the change os someone calling

   make wronglycasedtargetname_config

Or direct invocation of

  ./mkconfig -A wronglycasedtargetname

Regards
Henrik



More information about the U-Boot mailing list