[U-Boot] [PATCH v4 2/9] x86: Allow excluding reset vector code from u-boot

[Simon Glass]

Hi Wolfgang,

On Sun, Nov 25, 2012 at 10:53 PM, Wolfgang Denk <wd at denx.de> wrote:
> Dear Simon Glass,
>
> In message <1353910336-7193-3-git-send-email-sjg at chromium.org> you wrote:
>> From: Gabe Black <gabeblack at chromium.org>
>>
>> When running from coreboot we don't want this code.
>>
>> This version works by ifdef-ing out all of the code that would go
>> into those sections and all the code that refers to it. The sections are
>> then empty, and the linker will either leave them empty for the loader
>> to ignore or remove them entirely.
>
> Hm.... as is, this requires that we define CONFIG_SYS_X86_RESET_VECTOR
> in all x86 board config files, just because a single board
> configuration does not need this?  This makes no sense.  Please invert
> the logic.

That was how the previous patch worked (CONFIG_NO_RESET_CODE). If
required the ifneq in the Makefile though, which you objected to. Or
is there another way?

Also Graeme mentioned that all x86 boards will soon use Coreboot, so
the option (and the code) may in fact be removed one day. That's why I
was happy enough to invert it.

There are actually only 2 boards, enet and coreboot.

Regards,
Simon

>
> Best regards,
>
> Wolfgang Denk
>
> --
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> "The question of whether a computer can think is no more  interesting
> than the question of whether a submarine can swim"
>                                                 - Edsgar W.  Dijkstra