[U-Boot] [PATCH V3 3/4] lcd: calculate line_length after lcd_ctrl_init()

Albert ARIBAUD albert.u.boot at aribaud.net
Mon Nov 26 22:43:19 CET 2012


Hi Stephen,

On Fri, 9 Nov 2012 09:17:21 +0100, Anatolij Gustschin <agust at denx.de>
wrote:

> On Wed,  7 Nov 2012 23:38:32 -0700
> Stephen Warren <swarren at wwwdotorg.org> wrote:
> 
> > When an LCD driver is actually driving a regular external display, e.g.
> > an HDMI monitor, the display resolution might not be known until the
> > display controller has initialized, i.e. during lcd_ctrl_init(). However,
> > lcd.c calculates lcd_line_length before calling this function, thus
> > relying on a hard-coded resolution in struct panel_info.
> > 
> > Instead, defer this calculation until after lcd_ctrl_init() has had the
> > chance to dynamically determine the resolution. This needs to happen
> > before lcd_clear(), since the value is used there.
> > 
> > grep indicates that no code outside lcd.c uses this lcd_line_length; in
> > particular, no lcd_ctrl_init() implementations read it.
> > 
> > Signed-off-by: Stephen Warren <swarren at wwwdotorg.org>
> > --
> > v3: No change.
> > ---
> >  common/lcd.c |    3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> Acked-by: Anatolij Gustschin <agust at denx.de>

Sorry, but this one does not apply cleanly any more. Can you fix it, and
make sure 4/4 also applies on u-boot-arm/master? I'll apply all four
patches then.

Amicalement,
-- 
Albert.


More information about the U-Boot mailing list