[U-Boot] [PATCH 3/9] Only perform DFU board_usb_init() for TRATS
Marek Vasut
marex at denx.de
Wed Nov 28 03:45:04 CET 2012
Dear Pantelis Antoniou,
> USB initialization shouldn't happen for all the boards.
>
> Signed-off-by: Pantelis Antoniou <panto at antoniou-consulting.com>
> ---
> common/cmd_dfu.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/common/cmd_dfu.c b/common/cmd_dfu.c
> index 01d6b3a..327c738 100644
> --- a/common/cmd_dfu.c
> +++ b/common/cmd_dfu.c
> @@ -55,7 +55,10 @@ static int do_dfu(cmd_tbl_t *cmdtp, int flag, int argc,
> char * const argv[]) goto done;
> }
>
> +#ifdef CONFIG_TRATS
> board_usb_init();
> +#endif
> +
It's common code:
1) Why is it called "board_usb_init()" ? Does this have anything to do with usb
host?
2) Make it __weak, then if it's undefined for your board, something default will
be called.
> g_dnl_register(s);
> while (1) {
> if (ctrlc())
Best regards,
Marek Vasut
More information about the U-Boot
mailing list