[U-Boot] [PATCH 05/10] dfu: Only perform DFU board_usb_init() for TRATS

[Lukasz Majewski]

Hi Tom,

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> On 11/28/12 09:47, Lukasz Majewski wrote:
> > Hi Pantelis,
> > 
> >> USB initialization shouldn't happen for all the boards.
> >> 
> > 
> > The board_usb_init() follows u-boot policy, that SoC IPs (USB) are 
> > enabled and configured just before their usage.
> > 
> > 
> >> Signed-off-by: Pantelis Antoniou <panto at antoniou-consulting.com> 
> >> --- common/cmd_dfu.c | 3 +++ 1 file changed, 3 insertions(+)
> >> 
> >> diff --git a/common/cmd_dfu.c b/common/cmd_dfu.c index
> >> 01d6b3a..327c738 100644 --- a/common/cmd_dfu.c +++
> >> b/common/cmd_dfu.c @@ -55,7 +55,10 @@ static int do_dfu(cmd_tbl_t
> >> *cmdtp, int flag, int argc, char * const argv[]) goto done; }
> >> 
> >> +#ifdef CONFIG_TRATS board_usb_init(); +#endif +
> > In mine opinion this #ifdef shall be removed and each target board 
> > using the DFU shall define board_usb_init() at board file.
> > 
> 
> But this isn't a called-only-once place.  What are you really doing
> here and are you sure it's needed every time DFU is called?
> 

Hmm, you are correct here. 

But I don't have a good alternative for this.

One solution would be to define a static flag for it at do_dfu function
to indicate if this was executed once (however I'm reluctant do this). 


Any ideas?

> - -- 
> Tom
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.11 (GNU/Linux)
> Comment: Using GnuPG with Mozilla - http://www.enigmail.net/
> 
> iQIcBAEBAgAGBQJQtjM2AAoJENk4IS6UOR1WOu8P/3253rY48k6+NgCefiNZf6GH
> Sw9ZEh7fNkC3QgSkKA8/Ifa52F455UFpslftjSVHIrGIwIVc+3TCM2lOdbaBZgMi
> bL0MsPKRRbujx6U69lY5A6eaFyrhPJJJcCryFoPkfzsYSuvazol/crKCs9BB24Mk
> j35nvd2juxmhh4paQ9+7UVkxI50haLPVBHU7A5v8yv3i9/Cig+qwqewt+GWvIhoE
> w6frRy4WyczTClWqF+KwlfT4bwJVtnHxzfl5d2qRn4C/McTzUpwVePT8xrGaS4zc
> 3p+VCQ269Po176sgwoud5EwJdvCNBVfFeHaTORW8UJ2zLzU4iDixx4VY9SQhTfHF
> MP7Ch5p2DIJRrlEUWuRAgQwO6pICBHD+f3jw5q06hg35JWmTnltyq53M5UILGyi/
> Vz+SN0xF4YnMJRvKGT9lal0OiRxr/rO63k6fl2XybEfTED6AHhvUJKBV+yb1OxV0
> CTCiBRqfKQwkProdFtAAJT6+CeexV4Im2WcHQwqcKxVNqgEQhM6MBsM3DkjfE+nj
> naz8ITF6Lal1C0K5dUbSPiY8KqgphXre11wJ28BFp5WSM/p/0wCrhImXxuOMeUd3
> QtWT/BT2fJfKcr2bGVLTKdHVBHLWziJQK6IjO8rGnot2QbdSh+QS8n9ZrDf9rJYS
> +Ha0VT7jIVP/6uF1FXdj
> =puWb
> -----END PGP SIGNATURE-----



-- 
Best regards,

Lukasz Majewski

Samsung Poland R&D Center | Linux Platform Group