[U-Boot] [PATCH 1/3] tegra: only define TEGRA_DEVICE_SETTINGS if not already defined

Simon Glass sjg at chromium.org
Wed Nov 28 22:01:08 CET 2012


Hi Stephen,

On Wed, Nov 28, 2012 at 9:50 AM, Stephen Warren <swarren at wwwdotorg.org> wrote:
> From: Stephen Warren <swarren at nvidia.com>
>
> seaboard.h attempts to undefine TEGRA_DEVICE_SETTINGS and provide a
> custom value. This worked when the "pre" included tegra20-common.h
> provided the default. However, changes in the main U-Boot repo removed
> this default from the "pre" included tegra20-common.h to the "post"
> included tegra-common-post.h, which uncondtionally provides the value.
> This causes the following compile warnings:
>
> In file included from /home/swarren/shared/git_wa/u-boot/include/configs/seaboard.h:129:0,
>                  from /home/swarren/shared/git_wa/u-boot/include/config.h:10,
>                  from /home/swarren/shared/git_wa/u-boot/include/common.h:37,
>                  from lib/asm-offsets.c:18:
> /home/swarren/shared/git_wa/u-boot/include/configs/tegra-common-post.h:163:0: warning: "TEGRA_DEVICE_SETTINGS" redefined
> /home/swarren/shared/git_wa/u-boot/include/configs/seaboard.h:110:0: note: this is the location of the previous definition
>
> Solve this by modifying tegra-common-post.h to only provide a value for
> TEGRA_DEVICE_SETTINGS if the board-specific header has not already
> provided a custom value.
>
> Signed-off-by: Stephen Warren <swarren at nvidia.com>

These series doesn't apply to u-boot-tegra/master or /next for me, and
the last one doesn't seem to apply to u-boot/master either. Can you
please take a look, may be a timing issue.

Regards,
Simon


More information about the U-Boot mailing list