[U-Boot] [PATCH 2/2] net: add ICPlus PHY driver

[Marek Vasut]

Dear Yegor Yefremov,

> On Thu, Nov 29, 2012 at 3:29 PM, Marek Vasut <marex at denx.de> wrote:
> > Dear Yegor Yefremov,
> > 
> >> On Thu, Nov 29, 2012 at 1:55 PM, Marek Vasut <marex at denx.de> wrote:
> >> > Dear Yegor Yefremov,
> >> > 
> >> >> On Thu, Nov 29, 2012 at 8:53 AM, Henrik Nordström
> >> >> 
> >> >> <henrik at henriknordstrom.net> wrote:
> >> >> > tor 2012-11-29 klockan 07:27 +0100 skrev Marek Vasut:
> >> >> >> Dear yegorslists at googlemail.com,
> >> >> >> 
> >> >> >> > From: Yegor Yefremov <yegorslists at googlemail.com>
> >> >> >> > 
> >> >> >> > The driver code was taken from Linux kernel source:
> >> >> >> > drivers/net/phy/icplus.c
> >> >> >> > 
> >> >> >> > Signed-off-by: Yegor Yefremov <yegorslists at googlemail.com>
> >> >> >> 
> >> >> >> [...]
> >> >> >> 
> >> >> >> Is there any user for this PHY please?
> >> >> > 
> >> >> > I don't have one, but know at least one user having one in an A10
> >> >> > based "netbook".
> >> >> > 
> >> >> > http://linux-sunxi.org/File:H6-netbook-mainboard.jpg
> >> >> 
> >> >> I found these boards in kernel:
> >> >> 
> >> >> arch/mips/configs/malta_defconfig:CONFIG_ICPLUS_PHY=m
> >> >> arch/mips/configs/bcm47xx_defconfig:CONFIG_ICPLUS_PHY=m
> >> >> arch/mips/configs/ip27_defconfig:CONFIG_ICPLUS_PHY=m
> >> >> arch/mips/configs/sead3_defconfig:CONFIG_ICPLUS_PHY=y
> >> >> arch/powerpc/configs/mpc512x_defconfig:CONFIG_ICPLUS_PHY=y
> >> >> arch/powerpc/configs/52xx/motionpro_defconfig:CONFIG_ICPLUS_PHY=y
> >> >> arch/powerpc/configs/83xx/mpc832x_rdb_defconfig:CONFIG_ICPLUS_PHY=y
> >> >> arch/powerpc/configs/mpc83xx_defconfig:CONFIG_ICPLUS_PHY=y
> >> >> arch/powerpc/configs/ppc6xx_defconfig:CONFIG_ICPLUS_PHY=m
> >> > 
> >> > Sure, but the question/point is ... won't this be dead code in u-boot?
> >> > It won't once you add at least one board that actually uses it ...
> >> > adding it only so it's there will only cause it to bitrot and it'll
> >> > actually only add more burden to maintainers.
> >> 
> >> It won't be dead code, because we will use it :-) Our board is
> >> derivative of BeagleBone & Co, so the whole support stuff is already
> >> in u-boot.
> > 
> > You need to enable it for that board though ;-)
> 
> Will do this as soon as we come near to the release.

Release of what? The hardware?

> I'd like to have basic stuff mainlined before.

Well, I'll leave that up to Joe anyway

Best regards,
Marek Vasut