[U-Boot] [PATCH 1/2] mxs: Implement common function to setup VDDx

Marek Vasut marex at denx.de
Fri Nov 30 19:35:44 CET 2012


Dear Otavio Salvador,

> On Fri, Nov 30, 2012 at 1:22 PM, Marek Vasut <marex at denx.de> wrote:
> > Implement common function to setup the VDDIO, VDDD and VDDA voltage.
> > Right now, there are two almost identical functions to setup VDDIO
> > and VDDD, which is prone to breakage. Pull out the differences into
> > constant structure and pass them as an argument to the common function.
> > 
> > Moreover, the function has almost identical loops for setting higher
> > and lower VDDx voltage. Merge these two loops.
> > 
> > Signed-off-by: Marek Vasut <marex at denx.de>
> > Cc: Stefano Babic <sbabic at denx.de>
> > Cc: Fabio Estevam <fabio.estevam at freescale.com>
> 
> I like the code cleanup but I am curious if you have taken a look  if the
> mx23 one is compatible.

MX23 is unsupported in the mainline u-boot.

Best regards,
Marek Vasut


More information about the U-Boot mailing list