[U-Boot] Mac address warning

Tom Rini trini at ti.com
Fri Aug 2 16:45:04 CEST 2013


On Fri, Aug 02, 2013 at 04:36:23PM +0200, Stefano Babic wrote:
> Hi Tom,
> 
> On 02/08/2013 16:16, Tom Rini wrote:
> >> Well, I have found it very useful in case I set explicitely the
> >> ethaddr variable, so I know where the MAC address comes from. Do
> >> you find it disturbing ? Maybe we could replace "warning" with
> >> "info".
> > 
> > On am335x the message we use is: <ethaddr> not set. Validating
> > first E-fuse MAC And then validate it, and setenv.
> > 
> ..but the code is common as it is located in net/eth.c. The warning
> does not depend on the SOC.

Does it even belong there?  It looks like some generally unused and
dangling functionality, the "write" portion that is.  A number of
drivers do set write_hwaddr, but only usb_ether calls it, and not in an
update the HW fashion...

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130802/14c3b9f3/attachment.pgp>


More information about the U-Boot mailing list