[U-Boot] [PATCH] mmc: Initialize mmc_devices list statically

Taras Kondratiuk taras at ti.com
Tue Aug 6 18:41:57 CEST 2013


Currently mmc_device list is initialized from mmc_initialize() function.
So crash happens if any function which use mmc_devices list (find_mmc_device,
print_mmc_devices, etc.) is called before mmc_initialize().

Fix this by initializing mmc_devices list statically.

Signed-off-by: Taras Kondratiuk <taras at ti.com>
---
 drivers/mmc/mmc.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c
index 4da8db9..eb35582 100644
--- a/drivers/mmc/mmc.c
+++ b/drivers/mmc/mmc.c
@@ -21,7 +21,7 @@
 #define CONFIG_SYS_MMC_MAX_BLK_COUNT 65535
 #endif
 
-static struct list_head mmc_devices;
+LIST_HEAD(mmc_devices);
 static int cur_dev_num = -1;
 
 int __weak board_mmc_getwp(struct mmc *mmc)
@@ -1477,7 +1477,6 @@ static void do_preinit(void)
 
 int mmc_initialize(bd_t *bis)
 {
-	INIT_LIST_HEAD (&mmc_devices);
 	cur_dev_num = 0;
 
 	if (board_mmc_init(bis) < 0)
-- 
1.7.9.5



More information about the U-Boot mailing list