[U-Boot] [PATCH] powerpc/eeprom: update MAX_NUM_PORTS to fix program failure

Timur Tabi timur at tabi.org
Mon Aug 12 01:50:54 CEST 2013


On Thu, Aug 8, 2013 at 5:14 AM, Shengzhou Liu
<Shengzhou.Liu at freescale.com> wrote:
> On some boards, the size of EEPROM is 128 Bytes instead of 256.
> so we set default MAX_NUM_PORTS to 9 rather than previous 23 to
> avoid the programming failure, we can define MAX_NUM_PORTS in
> board-specific header file to overwrite the default value.

NACK.

If the EEPROM is 128 bytes, then you have a non-conformant EEPROM.
And using the #ifdef to determine this is definitely the wrong way.


More information about the U-Boot mailing list