[U-Boot] [PATCH v8 RESEND 2/2] console: usb: kbd: To improve TFTP booting performance

Marek Vasut marex at denx.de
Mon Aug 12 22:13:43 CEST 2013


Dear Stephen Warren,

> On 08/11/2013 12:08 PM, Marek Vasut wrote:
> > Dear Jim Lin,
> > 
> >> TFTP booting is slow when a USB keyboard is installed and
> >> stdin has usbkbd added.
> >> This fix is to change Ctrl-C polling for USB keyboard to every second
> >> when NET transfer is running.
> >> 
> >> diff --git a/include/usb.h b/include/usb.h
> >> 
> >> +extern int __maybe_unused net_busy_flag;
> > 
> > I wonder what would happen if you declared it here as
> > 
> > static int __maybe_unused
> > 
> > Would it have some side-effects?
> 
> Then each file that includes this header will get a separate copy of the
> variable.

Ah, you're right.

Best regards,
Marek Vasut


More information about the U-Boot mailing list