[U-Boot] [PATCH v1 1/4] mtd: nand: omap: enable BCH ECC scheme using ELM for generic platform

[Scott Wood]

On Tue, 2013-08-13 at 05:00 +0000, Gupta, Pekon wrote:
> > > - CONFIG_NAND_OMAP_ECC_BCH8_CODE_HW_DETECTION_SW
> > > Include API for S/W library (lib/bch.c) so included that here..
> > > But this ECC scheme should be used only for older OMAP platforms where
> > >  ELM is not present
> > >
> > > - CONFIG_NAND_OMAP_ECC_BCH8_CODE_HW
> > > Include declarations for ELM functions. So new OMAP platforms which
> > have
> > > ELM hardware engine, need not include whole bch.c library in their code.
> > 
> > Maybe it should just be something like CONFIG_SYS_OMAP_ELM?
> > 
> Actually is not just decides between using ELM or not. CONFIGs also
> selects which all ECC scheme to support (multiple selection allowed).
> 
> Following ECC schemes can be supported on omap-nand driver..
> [1] http://permalink.gmane.org/gmane.linux.ports.arm.omap/101028
> 
> So to keep code foot-print small, configs are used to select out some
> Un-needed ECC schemes on newer devices.

If the hardware doesn't dictate a specific choice, use CONFIG rather
than CONFIG_SYS, even if not all hardware supports all options.

-Scott