[U-Boot] [PATCH 06/10 v5] spl: env_common.c: make CONFIG_SPL_BUILD contain function env_import

Zhang Ying-B40530 B40530 at freescale.com
Wed Aug 14 04:31:58 CEST 2013


Hi, Tom,
	This patch hasn't been applied? I think it should be applied early and it is needed by other patches of this set.
	Thanks.

-----Original Message-----
From: Tom Rini [mailto:tom.rini at gmail.com] On Behalf Of Tom Rini
Sent: Friday, June 28, 2013 5:57 AM
To: Wood Scott-B07421
Cc: u-boot at lists.denx.de; Wood Scott-B07421; afleming at gmail.com; Zhang Ying-B40530
Subject: Re: [U-Boot] [PATCH 06/10 v5] spl: env_common.c: make CONFIG_SPL_BUILD contain function env_import

On Thu, Jun 27, 2013 at 03:16:34PM -0500, Scott Wood wrote:
> On 06/27/2013 07:17:48 AM, Tom Rini wrote:
> >On Thu, Jun 27, 2013 at 02:35:34AM +0000, Zhang Ying-B40530 wrote:
> >
> >> -----Original Message-----
> >> From: Tom Rini [mailto:tom.rini at gmail.com] On Behalf Of Tom Rini
> >[snip]
> >> Building for am335x_evm and am335x_evm_usbspl should tell you if
> >it is,
> >> or is not.  Whacking network support into SPL required more than 
> >> --gc-sections alone could give us and we needed to drop a few 
> >> couldn't-ever-reach calls and functionality out.
> >> [Zhang Ying]
> >> Yes, I tried to build for am335x_evm without this ifdef, no problem.
> >> Whether it can be removed?
> >
> >Did you also build am335x_evm_usbspl?
> 
> It builds OK for me with the ifdef removed.  It adds 81 bytes to the 
> SPL.

I think we can live with that.

Acked-by: Tom Rini <trini at ti.com>

--
Tom



More information about the U-Boot mailing list