[U-Boot] [PATCH] i.MX: Add documentation on how to use SPI NOR on MX28evk

Stefano Babic sbabic at denx.de
Wed Aug 14 14:59:53 CEST 2013


Hi Mårten,

On 13/08/2013 17:48, Mårten Wikman wrote:
> 2013/8/11 Otavio Salvador <otavio at ossystems.com.br>:
>> On Sun, Aug 11, 2013 at 10:49 AM, Mårten Wikman <marten.wikman at novia.fi> wrote:
>>> This adds necessary information on how to use U-boot on SPI NOR on MX28evk
>>>
>>> Signed-off-by: Marten Wikman <marten.wikman at novia.fi>
>>
>> Marten,
>>
>> The patch looks right and complete; I'd just split it in two patches:
>>
>> - add the new target
>> - add documentation
>>
>> From your commit log it is not clear you're adding the new target.
>>
>> --
>> Otavio Salvador                             O.S. Systems
>> http://www.ossystems.com.br        http://projetos.ossystems.com.br
>> Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
> 
> Should I split it into two and send is as PATCH v2 to the mailing list?

This is necessary - the two items documentation and new target are
orthogonal. Please do it in this way.

Best regards,
Stefano Babic


-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================


More information about the U-Boot mailing list