[U-Boot] [PATCH v4] SPL: Makefile: Build a separate autoconf.mk for SPL

[Tom Rini]

On Fri, Aug 16, 2013 at 03:14:44PM +0800, ying.zhang at freescale.com wrote:

> From: Ying Zhang <b40530 at freescale.com>
> 
> SPL defines CONFIG_SPL_BUILD but this does not percolate to the autoconf.mk Makefile.
> As a result the build breaks when CONFIG_SPL_BUILD is used in the board-specific include
> header file. With this, there is a possibility of having a CONFIG option defined in the
> header file but not defined in the Makefile causing all kinds of build failure and problems.
> 
> It also messes things for up, for example, when one might want to undefine options to
> keep the SPL small and doesn't want to be stuck with the CONFIG options used for U-boot.
> Lastly, this also avoids defining special CONFIG_SPL_ variables for cases where some
> options are required in U-boot but not in SPL.
> 
> We add a spl-autoconf.mk rule that is generated for SPL with the CONFIG_SPL_BUILD flag
> and conditionally include it for SPL builds.
> 
> Signed-off-by: Ying Zhang <b40530 at freescale.com>
> ---
> Change from v3:
> - No change.
> Change from v2:
> - Fixed the reported build breakage of am335x_evm_usbspl.
> Change from v1:
> - Fixed issue where builds in a different directory were failing.

Uh, this is Joel's patch and you dropped his authorship when picking it
up.  I'm glad to see you picking it up and addressing the last of the
issues I reported (right?), but you need to retain Joel's Author/SOB and
add your own for any further changes you've made here.  Thanks.

And please make sure a MAKEALL passes for both powerpc and arm.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130816/22b97584/attachment.pgp>