[U-Boot] legacy I2C_GET_BUS()/I2C_SET_BUS() not working anymore

[Lukasz Majewski]

On Fri, 16 Aug 2013 11:43:58 +0200 Dirk Eibach
dirk.eibach at googlemail.com wrote,
> Hello Heiko,
> 
> your commit 385c9ef5 introduced in include/i2c.h

Hi Dirk,

I've posted fix for it on late friday:

http://patchwork.ozlabs.org/patch/267651/

> 
> #if defined(CONFIG_SYS_I2C) || defined(CONFIG_I2C_MULTI_BUS)
> # if !defined(CONFIG_SYS_MAX_I2C_BUS)
> #  define CONFIG_SYS_MAX_I2C_BUS 2
> # endif
> # define I2C_MULTI_BUS 0
> #else
> # define CONFIG_SYS_MAX_I2C_BUS 1
> # define I2C_MULTI_BUS 0
> #endif
> 
> which does not seem to be correct as we end up with I2C_MULTI_BUS set
> to 0 in any case.
> 
> static inline void I2C_SET_BUS(unsigned int bus)
> {
> if (I2C_MULTI_BUS)
> i2c_set_bus_num(bus);
> }
> 
> This means that  I2C_GET_BUS()/I2C_SET_BUS() does not work anymore. I
> stumbled upon this as we are using these legacy funtions in
> controlcenterd (which will be changed in the next mergewindow).
> 
> Cheers
> Dirk



-- 
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group