[U-Boot] [U-Boot, v1, 5/8] fsl: do not define FSL_SRIO_PCIE_BOOT_MASTER for all P2041 systems

Valentin Longchamp valentin.longchamp at keymile.com
Mon Aug 19 17:26:55 CEST 2013


On 08/13/2013 10:32 PM, York Sun wrote:
> On 07/26/2013 03:02 AM, Valentin Longchamp wrote:
>> If this #define stays in config_mpc85xx.h, the P2041 based boards must
>> define a lot of SRIO values even if they do not implement a SRIO device.
>>
>> The #define is moved into the P2041RDB board config file where it is
>> used.
>>
>> Signed-off-by: Valentin Longchamp <valentin.longchamp at keymile.com>
>>
>> ---
>> include/configs/P2041RDB.h | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/include/configs/P2041RDB.h b/include/configs/P2041RDB.h
>> index 4ea8717..523117b 100644
>> --- a/include/configs/P2041RDB.h
>> +++ b/include/configs/P2041RDB.h
>> @@ -399,6 +399,7 @@ unsigned long get_board_sys_clk(unsigned long dummy);
>>   * for slave u-boot IMAGE instored in master memory space,
>>   * PHYS must be aligned based on the SIZE
>>   */
>> +#define CONFIG_SYS_FSL_SRIO_PCIE_BOOT_MASTER
>>  #define CONFIG_SRIO_PCIE_BOOT_IMAGE_MEM_PHYS 0xfef080000ull
>>  #define CONFIG_SRIO_PCIE_BOOT_IMAGE_MEM_BUS1 0xfff80000ull
>>  #define CONFIG_SRIO_PCIE_BOOT_IMAGE_SIZE 0x80000	/* 512K */
> 
> I failed to see what problem this patch fixes. Maybe you were using an
> older copy of u-boot?
> 

I developped all this with an earlier version of u-boot and I missed this one as
I rebased. You are right, this is not needed and fixes nothing.

Valentin



More information about the U-Boot mailing list