[U-Boot] [PATCH v6 1/2] exynos5250: Add arndale board support

[Kim Phillips]

On Tue,  6 Aug 2013 20:05:46 +0530
Chander Kashyap <chander.kashyap at linaro.org> wrote:

> Arndale board is based on samsung's exynos5250 soc.
> 
> Signed-off-by: Inderpal Singh <inderpal.singh at linaro.org>
> Signed-off-by: Chander Kashyap <chander.kashyap at linaro.org>
> ---

This patchseries gives me:

make[1]: Entering directory `/home/kim/git/u-boot-arndale-upstream/board/samsung/arndale'
arm-linux-gnueabihf-gcc  -g  -Os   -ffunction-sections -fdata-sections -fno-common -ffixed-r8 -msoft-float  -D__KERNEL__ -DCONFIG_SYS_TEXT_BASE=0x43E00000 -DCONFIG_SPL_TEXT_BASE=0x02023400 -DCONFIG_SPL_PAD_TO=0 -I/home/kim/git/u-boot-arndale-upstream/include -fno-builtin -ffreestanding -nostdinc -isystem /home/kim/toolchain/gcc-linaro-arm-linux-gnueabihf-4.8-2013.07-1_linux/bin/../lib/gcc/arm-linux-gnueabihf/4.8.2/include -pipe  -DCONFIG_ARM -D__ARM__ -marm -mno-thumb-interwork -mabi=aapcs-linux -march=armv7-a -Wall -Wstrict-prototypes -fno-stack-protector -Wno-format-nonliteral -Wno-format-security -fstack-usage     -o arndale.o arndale.c -c
arndale.c: In function ‘board_uart_init’:
arndale.c:74:11: error: ‘ret’ undeclared (first use in this function)
    return ret;
           ^
arndale.c:74:11: note: each undeclared identifier is reported only once for each function it appears in
arndale.c:78:1: warning: control reaches end of non-void function [-Wreturn-type]
 }
 ^
make[1]: *** [arndale.o] Error 1
make[1]: Leaving directory `/home/kim/git/u-boot-arndale-upstream/board/samsung/arndale'

I manually fixed it with:

diff --git a/board/samsung/arndale/arndale.c b/board/samsung/arndale/arndale.c
index 6d81b90..4e021c3 100644
--- a/board/samsung/arndale/arndale.c
+++ b/board/samsung/arndale/arndale.c
@@ -71,10 +71,10 @@ static int board_uart_init(void)
                if (err) {
                        debug("UART%d not configured\n",
                                (uart_id - PERIPH_ID_UART0));
-                       return ret;
+                       return err;
                }
        }
-       return ret;
+       return err;
 }
 
 #ifdef CONFIG_BOARD_EARLY_INIT_F

btw, I noticed that misaligned parenthesis above, and asked checkpatch
if it did, and it did:

CHECK: Alignment should match open parenthesis
#73: FILE: samsung/arndale/arndale.c:73:
+			debug("UART%d not configured\n",
+				(uart_id - PERIPH_ID_UART0));

so it's obvious that you're not build-testing nor running checkpatch
between each patchseries version submission.

Even after fixing the above, I get:

arm-linux-gnueabihf-objcopy --gap-fill=0xff -O binary /home/kim/git/u-boot-arndale-upstream/spl/u-boot-spl /home/kim/git/u-boot-arndale-upstream/spl/u-boot-spl.bin
/home/kim/git/u-boot-arndale-upstream/tools/mkarndalespl \
		/home/kim/git/u-boot-arndale-upstream/spl/u-boot-spl.bin /home/kim/git/u-boot-arndale-upstream/spl/arndale-spl.bin
/bin/bash: line 1: /home/kim/git/u-boot-arndale-upstream/tools/mkarndalespl: No such file or directory
make[1]: *** [/home/kim/git/u-boot-arndale-upstream/spl/arndale-spl.bin] Error 127
make[1]: Leaving directory `/home/kim/git/u-boot-arndale-upstream/spl'
make: *** [spl/u-boot-spl.bin] Error 2

this is v6 of the patchseries - could you *please* establish a decent
test regimen prior to your patch submissions?

Thanks,

Kim