[U-Boot] should print_mmc_devices() not add an extraneous blank between devices?
Robert P. J. Day
rpjday at crashcourse.ca
Tue Aug 20 22:46:58 CEST 2013
playing on my beaglebone black and:
U-Boot# mmc list
OMAP SD/MMC: 0
OMAP SD/MMC: 1 <-- ???
U-Boot#
puzzled as to why the second line is indented, and discovered, first
from cmd_mmc.c:
print_mmc_devices('\n');
which reasonably defines a newline as a separator, but then there's
this in drivers/mmc/mmc.c:
list_for_each(entry, &mmc_devices) {
m = list_entry(entry, struct mmc, link);
printf("%s: %d", m->name, m->block_dev.dev);
if (entry->next != &mmc_devices)
printf("%c ", separator);
}
where that loop inserts the separator *and* a blank. is that
deliberate? it just looks weird.
rday
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
More information about the U-Boot
mailing list