[U-Boot] [PATCH v3 17/21] arm: Implement the 'fake' go command

[Simon Glass]

Hi Vb,

On Wed, Aug 21, 2013 at 3:59 PM,  <vb at vsbe.com> wrote:
> On Wed, Jun 19, 2013 at 9:15 PM, Simon Glass <sjg at chromium.org> wrote:
>>
>> Implement this feature on ARM for tracing.
>>
>> It would be nice to have generic bootm support so that it is easily
>> implemented on any arch.
>>
>> Signed-off-by: Simon Glass <sjg at chromium.org>
>> ---
>> Changes in v3:
>> - Revert to using 'images' instead of 'image' in boot_jump_linux()
>>
>> Changes in v2: None
>>
>>  arch/arm/lib/bootm.c | 27 ++++++++++++++++++---------
>>  1 file changed, 18 insertions(+), 9 deletions(-)
>>
>> diff --git a/arch/arm/lib/bootm.c b/arch/arm/lib/bootm.c
>> index 1b6e0ac..b22fbc9 100644
>> --- a/arch/arm/lib/bootm.c
>> +++ b/arch/arm/lib/bootm.c
>> @@ -68,12 +68,19 @@ void arch_lmb_reserve(struct lmb *lmb)
>>                     gd->bd->bi_dram[0].start + gd->bd->bi_dram[0].size - sp);
>>  }
>>
>> -static void announce_and_cleanup(void)
>> +/**
>> + * announce_and_cleanup() - Print message and prepare for kernel boot
>> + *
>> + * @fake: non-zero to do everything except actually boot
>> + */
>> +static void announce_and_cleanup(int fake)
>>  {
>> -       printf("\nStarting kernel ...\n\n");
>> +       printf("\nStarting kernel ...%s\n\n", fake ?
>> +               "(fake run for tracing)" : "");
>>         bootstage_mark_name(BOOTSTAGE_ID_BOOTM_HANDOFF, "start_kernel");
>>  #ifdef CONFIG_BOOTSTAGE_FDT
>> -       bootstage_fdt_add_report();
>> +       if (flag == BOOTM_STATE_OS_FAKE_GO)
>> +               bootstage_fdt_add_report();
>>  #endif
>
> was this ever compiled  with CONFIG_BOOTSTAGE_FDT defined? `flag' is
> not defined here, compilation fails for me when I try enabling this
> config...

I am not sure of the answer to your question, but if you have fixed
this problem you could submit a patch - it would be welcome.

Regards,
Simon