[U-Boot] [U-Boot, resend, v3, 5/5] ARM: at91: atmel_nand: add code to check the ONFI parameter ECC requirement

Andreas Bießmann andreas.devel at googlemail.com
Thu Aug 22 17:01:03 CEST 2013


Dear Josh Wu,

Josh Wu <Josh.wu at atmel.com> writes:
>1. if CONFIG_SYS_NAND_ONFI_DETECTION is defined, driver will check NAND flash's
>   ecc minimum requirement in ONFI parameter.
>
>  a) if CONFIG_PMECC_CAP, CONFIG_PMECC_SECTOR_SIZE are defined. then use it.
>     Driver will display a WARNING if the values are different from ONFI
>     parameters.
>
>  b) if CONFIG_PMECC_CAP, CONFIG_PMECC_SECTOR_SIZE are not defined, then use
>      the value from ONFI parameters.
>      * If ONFI ECC parameters are in ONFI extended parameter page, since we
>        are not support it, so assume the minimum ecc requirement is 2 bits
>        in 512 bytes.
>      * For non-ONFI support nand flash, also assume the minimum ecc
>        requirement is 2 bits in 512 bytes.
>
>2. if CONFIG_SYS_NAND_ONFI_DETECTION is not defined, just use CONFIG_PMECC_CAP
>   and CONFIG_PMECC_SECTOR_SIZE.
>
>Signed-off-by: Josh Wu <josh.wu at atmel.com>
>Acked-by: Scott Wood <scottwood at freescale.com>
>---
>resend:
>  use braces around muti-line if/loop body.
>
>v2 --> v3:
>  use dev_err/info(host->dev) instead of dev_err/info(NULL).
>  use MTDDEBUG() instead of pr_debug().
>
>v1 --> v2:
>  use dev_err/info to replace printk.
>  fix typo mistake, that should use <= instead of use <.
>
> drivers/mtd/nand/atmel_nand.c |  130 ++++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 128 insertions(+), 2 deletions(-)

applied to u-boot-atmel/master, thanks!

Best regards,
Andreas Bießmann


More information about the U-Boot mailing list