[U-Boot] [PATCH v9 2/2] console: usb: kbd: To improve TFTP booting performance

Marek Vasut marex at denx.de
Mon Aug 26 18:28:07 CEST 2013


Dear Stephen Warren,

> On 08/26/2013 05:31 AM, Marek Vasut wrote:
> > Dear Jim Lin,
> > 
> >> Marek,
> >> In common/usb_kbd.c, you applied code to wrong place.
> >> You should apply my change to function usb_kbd_testc(), instead of
> >> usb_kbd_getc(). Could you help to correct it?
> > 
> > I believe I applied your patches. Anyway, submit a subsequent patch
> > against u- boot-usb/master please.
> 
> Marek, did you apply the patch using "git am", "patch", or by
> hand-editing? Looking at the fixup patch that Jim sent, the patch
> context is identical in both places, so perhaps this exposed some issue
> with git/... - it'd be useful to understand how the problem occurred, so
> it can be fixed.

git am ... and you're right, this is somewhat strange.

Best regards,
Marek Vasut


More information about the U-Boot mailing list